Eddie Torres

Tested changes, this revision lgtm. ``` storageclass.yaml > apiVersion: snapshot.storage.k8s.io/v1 kind: VolumeSnapshotClass metadata: name: csi-aws-vsc driver: ebs.csi.aws.com parameters: tagSpecification: "key1=value1" deletionPolicy: Delete ``` ``` $ kubectl apply -f manifests/classes/ volumesnapshotclass.snapshot.storage.k8s.io/csi-aws-vsc...

/lgtm /unhold

Hey, thanks for this. I agree that the example policy is too lax, but I am concerned this change could inconvenience users since the policy will no longer work without...

Thanks! /ok-to-test /lgtm /hold cc: @gtxu

Hi, can you please fill out the bug report template? https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/ISSUE_TEMPLATE/bug_report.md Be sure to include driver version. If possible, also provide your deployment or a sample, and instance type (Nitro?)...

I believe this is expected behavior, if you terminate your EC2 instance ungracefully (i.e. without safely evicting all of your pods through `kubectl drain`) the pods that are part of...

@amitde69 [ReconcilerMaxWaitForUnmountDuration](https://github.com/kubernetes/kubernetes/blob/3f579d8971fcce96d6b01b968a46c720f10940b8/pkg/controller/volume/attachdetach/attach_detach_controller.go#L94) is currently not configurable: https://github.com/kubernetes/kubernetes/issues/105341. The previously mentioned [KEP](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2268-non-graceful-shutdown#:~:text=%5BProposed%20change%5D%20Once,to%20be%20deleted.) addresses this 6 minute wait time by issuing a force detach if the `out-of-service` taint is present on the...

/lifecycle frozen

Hey @christianhuening @fzyzcjy @vlerenc, can you provide environment details and specify the driver version being used? As previously mentioned, authorization to get `volumeattachments` is handled by the [node authorizer](https://github.com/kubernetes/kubernetes/pull/58360) so...

If you run into this while upgrading please read @ConnorJC3's comment above and take a look at the Helm chart [release notes](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/CHANGELOG.md), thanks.