Tor Erlend Fjelde comments

Results 693 comments of


                                            Tor Erlend Fjelde

Rework of how transformations are handled

Aight, so it seems we weren't really testing cases such as ```julia product_distribution(fill(Dirichlet(ones(4)), 2, 3)) ``` (which might be because we didn't have support for this in Bijectors.jl until recently),...

Rework of how transformations are handled

Thanks @mhauru

Rework of how transformations are handled

Looks like everything is passing nicely:)

Rework of how transformations are handled

Does this count the images? Or is it just the HTML?

Default float type to float(Real), not Real (#685)

> Also, the ReverseDiff tests only fail on

Default float type to float(Real), not Real (#685)

Isn't it a bit annoying to just merge this if the CI is failing? IMO we hsould really at least identify _why_ ReverseDiff is failing. From the logs it just...

Default float type to float(Real), not Real (#685)

> To be clear, I consider a review approval to be orthogonal to seeing tests pass, i.e. generally we should have both. Thus I often approve on a basis of...

Default float type to float(Real), not Real (#685)

> Do you have the logs @penelopeysm ? Happy to bump the version to LTS, as we shouldn't maintain older versions if it's burden 👍 But useful if we know...

Default float type to float(Real), not Real (#685)

> If we have lots of "disable this on 1.6" or "if version < 1.7 then @test_broken", it is basically untested code. Definitively not pro this 👍 My point is...

Extension for MarginalLogDensities.jl

A bit uncertain if we should `export` this `marginalize` or hide it for now.