Tor Erlend Fjelde
Tor Erlend Fjelde
> I was wondering what is stopping this PR from being merged? > I've had this page in my open tabs for a few weeks now, anxiously awaiting the purple...
In the process of writing up the design, I realized the current growing and shrinking mechanism is a bit flawed. I've done quite a bit of work on this locally,...
I'm quite confused as to what's happening with the doctests. The by eye, it seems like the evaluated outputs are the same as desired output o.O Seen this before @yebai...
Sorry for late reply to this; had to do a fair bit of work to even just get this working properly, but finally made some significant progress on this. Immediate...
Something fishy is going on; the tests are passing but then CodeCov just fails when trying to run, causing the entire CI to fail :thinking:
Sorry, yesterday was packed. But I see you've gotten started already; awesome stuff:) Will have a look at the PR later today 👍 > What's the plan for the old...
> Should VarNameVector still be made to work with the old Gibbs sampler, or can that combo error? It seems Metadata has the gid field specifically for the Gibbs sampler,...
Is the CI failings related to this PR or is it something else?
Replied to the comments @mhauru , only _very_ minor changes suggested, aaaand then I think we're good to maybe hit that big green button :eyes:
I unfortuantely can't approve this because I'm still technically the "owner" of the PR, but this is looking good to me :tada: