Tor Erlend Fjelde
Tor Erlend Fjelde
Lovely; thanks @mhauru !
> This seems to build on https://github.com/TuringLang/DynamicPPL.jl/pull/555, so merging this will also merge https://github.com/TuringLang/DynamicPPL.jl/pull/555. Is the idea to do everything in this one and then merge all together? Actually, no...
Sounds like a plan:) And thanks for the comments!
I believe this should be ready for a final review:) Note that the PR is breaking, as we used to export the `vectorize` functions, etc.
> A high-level question: does one construct the from_linked_internal_transform for every model evaluation pass? If so, what are the performance implications? Yep! In many cases, none because it's still type-infereable...
> I am converting diagrams to DocumenterMermaid! Lovely! Note however that AFAIK we currently can't achieve "feature parity" with my diagrams (no syntax highlighting), as I've discussed in the other...
> I suggest you add your explanation to the documentation and also say this istrans check can be removed later. Sure, can do 👍 I thought I had already mentioned...
> I was and am still a bit confused by what transform and link mean and how they compare. I have a feeling that: "transform" is about mapping from values...
Anything holding this up still?
Lovely; will have a pass over now