Tom Prince

Results 62 comments of Tom Prince

I was looking into this, and the only commands that wouldn't fall under `cargobomb experiment` are `prepare-local` and `create-lists`.

(Given the restricted command list exposed in #24).

https://ghc.haskell.org/trac/ghc/wiki/ViewPatterns is a proposal for something similar in haskell (and the bottom has links to other proposals)

I think this is at least partially an issue with twisted. If I remove [this line](https://github.com/twisted/twisted/blob/4edc214ce9ca61950dd613b4d2dbb6fa8df28efd/src/twisted/internet/defer.py#L911), then the correct traceback is printed. Thus, it looks like it happens when an...

> Haven't tested that, though, so not sure how well it works compared to current solution Changing https://github.com/itamarst/eliot/blob/8609d380866491abe9e97eb814e4a04478b5893e/eliot/_generators.py#L111 to be ```python value_out = go() ``` makes the twisted tests still...

> Seems like it should always serialize all messages and just report multiple errors if it finds them, given what it does. That seems sensible. > Any interest in submitting...

It isn't entirely clear to me that this is too verbose, at least absent tool support for re-interpolating the fields from those messages that don't have them.

Note that ``` DeferredContext(self._request('GET', '/foos')).result ``` is a no-op (other than the validation). `DeferredContext` can't reach into the the call to `self._request` and make any callbacks added there get run...

Although, it might be nicer if it just wrote a log-file with everything as eliot logs.

The first idea was just changing the log to be JSON in the normal eliot JSON but in the twisted log file, and using a post-filter (like included in https://clusterhq.atlassian.net/browse/FLOC-2097).