Tom Prince

I do think having a new log that just supplants `_trial_temp/test.log` is the better option.

I suspect this is probably valid, but I'll note the original example can be simplified to: ``` python with an_action.context(): context = DeferredContext(some_function(args)) return context.addActionFinish() ```

Maybe something like ``` set makeprg=all-todos\ % set erroformat=%E%f:%l:%s:,%Z,%C%m ```

Hmmm. A work around would be to pass `--function-context` (`-W`) to `git-diff`, which will give the entire class or function that contains any change. Looking at how that is implemented,...

``` patch diff --git a/flocker/node/agents/blockdevice.py b/flocker/node/agents/blockdevice.py index 540fcac..b5565f9 100644 --- a/flocker/node/agents/blockdevice.py +++ b/flocker/node/agents/blockdevice.py @@ -1078,175 +1078,191 @@ def get_blockdevice_volume(api, blockdevice_id): @implementer(ILocalState) class BlockDeviceDeployerLocalState(PClass): """ An ``ILocalState`` implementation for the ``BlockDeviceDeployer``....

I don't care about speed, simply usage.

I think `TokenKind` is a better name than `TokenType`. It lines up better with all the `ErrorKind` enums, which serve a similar purpose.

One thing that I noticed when implementing a very simple consumer of full_moon, is that there are a lot places where you need to destructure enums where by the design...

Looking at the implementation in `proc_macro2`, it looks like they have a dummy file, that is used for spans that aren't tied to a specific place.

I've not used it just looked at the code[1], but it gets represented as something like `:0:0. In `syn`, one of the things spans gets used for is things like...