metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard
verified publisher icon MetaMask

feat(swaps): enable Base for swaps

Open nikoferro opened this issue 1 year ago • 23 comments

Description

This PR enables Base for swaps. Related to this, it also upgrades @metamask/swaps-controller to v8.0.0. See package.json and yarn.lock changes

Related issues

Depends on @metamask/swaps-controller to v8.0.0

Manual testing steps

  1. Enable swaps on base feature flag
  2. Change network to base
  3. Get a quote for a Swap

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

nikoferro avatar Apr 17 '24 13:04 nikoferro

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar Apr 17 '24 13:04 socket-security[bot]

@nikoferro looks like the @ts-expect-error directives here can be removed now with the swaps controller update?

legobeat avatar Apr 18 '24 07:04 legobeat

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 18 '24 08:04 github-actions[bot] 

@SocketSecurity ignore npm/@cypress/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

network access ok

legobeat avatar Apr 18 '24 08:04 legobeat 

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

new authors ok

legobeat avatar Apr 18 '24 08:04 legobeat 

@SocketSecurity ignore npm/@metamask/[email protected]

incomplete metadata ok

legobeat avatar Apr 18 '24 08:04 legobeat

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5578185bda5933b130a4440d66e59b5664b12a69 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53f0afde-46eb-4bf8-80da-94fe70221ccb

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Apr 18 '24 09:04 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e79f24d96b415f6a32bd68c0beaf2eee75df513e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e87f2333-79ae-49f9-b404-326585635d81

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Apr 18 '24 09:04 github-actions[bot] 

@SocketSecurity ignore npm/[email protected]

network access ok

legobeat avatar Apr 22 '24 10:04 legobeat

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c15819453169993358bf7f4fd6d7b50c86c07054 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/830b4f28-753d-4135-9c57-02889c4f19c8

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Apr 23 '24 13:04 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f1d7fdde25430a7b466e8231e41098312464b3fb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b31b79b-2173-4d56-b39b-39dd4dc5ec6f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Apr 25 '24 02:04 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: filesystem, network +46 41.3 MB gudahtt
npm/[email protected] None 0 31 kB sheetjs
npm/[email protected] Transitive: filesystem, network +7 1.41 MB luu-alex
npm/[email protected] None 0 405 kB jdevcs
npm/[email protected] None +1 1.4 MB luu-alex
npm/[email protected] None +3 33.6 MB luu-alex
npm/[email protected] None +9 35.4 MB luu-alex
npm/[email protected] None 0 135 kB jdevcs
npm/[email protected] None 0 300 kB luu-alex
npm/[email protected] None 0 523 kB luu-alex
npm/[email protected] None 0 304 kB luu-alex
npm/[email protected] network 0 137 kB pwnall
npm/[email protected] None 0 0 B

🚮 Removed packages: npm/@metamask/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Apr 25 '24 14:04 socket-security[bot]

Hey @nikoferro, awesome work! I see dedupe issues, can you solve those, please?

tommasini avatar Apr 26 '24 09:04 tommasini

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: be2169c375fcbe2171a5639c8ebc0c5bc6ff1528 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/489a27a2-8a50-42ea-8fd5-6bc0f86759b6

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Apr 26 '24 10:04 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ee21ca9c200a777aa90705ac144ecdb854501afb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16583530-8bfb-44b2-a70a-37f7771db60c

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Apr 26 '24 11:04 github-actions[bot]

@nikoferro Could you run a yarn deduplicate and commit the results?

legobeat avatar Apr 30 '24 20:04 legobeat

@nikoferro Could you run a yarn deduplicate and commit the results?

I went ahead and sorted this in 6f8d028e3a005f522456aaa8f546eba27d599314.

legobeat avatar May 02 '24 01:05 legobeat

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6f8d028e3a005f522456aaa8f546eba27d599314 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59a75de0-c987-429b-887c-405d3fb0978e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 02 '24 01:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 69e87edff6fdfaaac73c67578e3ba2c04dcb9821 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd6978d9-a0ec-42bc-816a-53fd9a65977f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 06 '24 11:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4061b1770da9fc67805fc7e1662a9e5e124e53c4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbd34bea-c6d7-44a3-86ff-9abd77609051

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 06 '24 20:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6a2f3939ca9af726993bffafd6c428879d9f280e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b3ae14ad-90b6-4f1d-b2b4-f861b8977668

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 07 '24 20:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 27359d460962f325de7f184b176e2abb32503c84 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc3f4c1b-78a6-4608-aacf-6c40484a7499

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 08 '24 20:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c6de9976f93d951fed3720ceb26f7e18ce0c14ac Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/98bbee6d-9bfe-4631-83ef-284c0a0d1a6a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 09 '24 03:05 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 09 '24 03:05 sonarqubecloud[bot]