Tom Lau

Results 26 comments of Tom Lau

thanks for you suggestions, i will try to implement these features in my free time :smile:

duplicate of https://github.com/LuaLS/lua-language-server/issues/2384 And as I commented there:https://github.com/LuaLS/lua-language-server/issues/2384#issuecomment-2198052928, `undefined-field` diagnostics only check for typed tables (for performance reason I guess), but the **enum binded table** are not typed. If somehow...

Actually you don't need to follow my annotation practice exactly 😂 (I mean the TestEnum`.*`) You can keep you enum type name as `TestEnum`, then name the underlying class to...

Like many of us, the author has a full time job. 😅 The amazing thing about open source projects is that **contributions are welcome**, and maybe we can fix something...

I tested the patch and it works (can throw undefined error) 🎉 . But seems there is a **side effect**: - when hover preview over the table, the content is...

The following 2 related/duplicated issues can also be closed: - https://github.com/LuaLS/lua-language-server/issues/1750 - https://github.com/LuaLS/lua-language-server/issues/2384

duplicate of https://github.com/LuaLS/lua-language-server/issues/1750 I guess this is because the `undefined field` check is only done for **typed table**, and `---@enum` doesn't treat the binded table as **typed** (it's creating an...

> Can it return 1 when problems found > Hard, because script/cli/check.lua use multi process, main process cannot know if sub process find error. I guess main process can know...

> using a a wrapper and checking check.json file contents after the run. Isn't that `check.json` will always be created no matter if there are problems or not? When no...

Our team is facing this same issue recently in github action since its latest runner image updated docker version to v23+ which uses BuildKit as default build engine. Our original...