Tom Hughes

Results 943 comments of Tom Hughes

Are we every likely to have anything else in `Features` though? Maybe it should just be `FeatureQueries` instead? Also should it be singular `Query` rather than `Queries`?

Yes I'm aware of this problem already and I assume it's a rails bug given that initializer is straight from upstream rails. I discovered it when I tried to switch...

Yes this is the trace of it getting loaded: ``` /usr/local/share/gems/ruby/3.0.0/gems/actionpack-7.0.2.3/lib/action_controller/metal/redirecting.rb:13:in `block in ': ActionController (RuntimeError) from /usr/local/share/gems/ruby/3.0.0/gems/activesupport-7.0.2.3/lib/active_support/concern.rb:136:in `class_eval' from /usr/local/share/gems/ruby/3.0.0/gems/activesupport-7.0.2.3/lib/active_support/concern.rb:136:in `append_features' from /usr/local/share/gems/ruby/3.0.0/gems/actionpack-7.0.2.3/lib/action_controller/base.rb:255:in `include' from /usr/local/share/gems/ruby/3.0.0/gems/actionpack-7.0.2.3/lib/action_controller/base.rb:255:in `block in '...

I definitely think it would be a good idea to switch to Debian but beyond that I don't really have much advice. Does debian not have a packaged geckodriver that...

No we don't have an enterprise account. What permissions exactly will the token need?

Yes but having seen how they configure their own secret I'm not trusting them to tell me how to do it! Working on a proper solution now...

The automatic token should be fine if we do things right - no need to configure a separate one.

Let's see if https://github.com/openstreetmap/openstreetmap-website/commit/6d0c2913326fbfdf3578416853e31d7a950d97ed helps...

Because it serves no purpose - nothing in the danger code ever looks at that.

Incidentally the "example" in the danger repo at https://github.com/danger/danger/blob/master/.github/workflows/CI.yml is not what it seems - if you look closely it never actually runs danger, it just echos the command that...