Tomas Jakobsson

Results 15 comments of Tomas Jakobsson

This is an area of ES that I have not touched much, so I can't really give any input on this.

Only done some quick test, and as mentioned, this requires locale to be changed from "C" to "", which breaks other things, (most noticeable is that Carbon theme layout broke)...

Yeah that's not the latest VIP Carbon, and that's beside the point, if this breaks the current VIP Carbon, it might break many other themes, which is why this needs...

I just tested it on "normal" Carbon and it flatout crashes with locale( "" ), and now I remember why I chose to use locale( "C" ) when I removed...

I also did some benchmarking ``` Function NumCalls Time toUpper 142095 0.062938 toUpperNew 142095 7.365905 ``` It added 7 seconds to starting up ES and that is not an impact...

This is gonna be a long comment, but I have now done quite a bit of testing. I wanna point out that all my tests have been done on Windows...

They use mbstowcs and wcstombs which should not be windows specific.

Well no, not really, that thing has been solved by setting ```cpp std::setlocale(LC_NUMERIC, "C"); ``` The problem is what locale the global locale should be set to, it can't be...

2 issues with this PR is the 2 spaces instead of tabs and that this will not compile on windows

Not sure what this is supposed to fix? You can have a portable setup in Windows using a batch file ( that's how I have done it the past 2...