Add grid view scroll sound and adjust sound theming

[benjdero]

Current behavior in normal text. Changes in bold. Suggestions in italic.

• Game list views

  • The Basic/Detailed/Video views use TextListComponent's own property scrollSound. It is not removed. If both are defined, the global scroll sound is used. Add scroll sound to the Grid view. Maybe games views could use the SYSTEM scroll sound when using quick system change
  • Play the launch sound when launching a game. Now it also do when entering a folder. Maybe entering a folder should use the scroll sound instead.
  • Play the back sound when exiting a folder. Now it also do when going back to system view

• System view

  • Add scroll sound to the system view
  • Add launch sound when a system is chosen

Syntax:

<view name="basic, detailed, video, grid">
	<sound name="scroll">
		<path>./game_scroll.wav</path>
	</sound>
	<sound name="launch">
		<path>./game_launch.wav</path>
	</sound>
	<sound name="back">
		<path>./game_back.wav</path>
	</sound>
</view>
<view name="system">
	<sound name="scroll">
		<path>./system_scroll.wav</path>
	</sound>
	<sound name="launch">
		<path>./system_launch.wav</path>
	</sound>
</view>

You can test it by using my modified version of @lilbud 's material theme that you can find here

It should fix #485 and #155 and the numerous requests people did on the forum to add scroll sounds to the grid view.

Tests and feedbacks from users and theme designers would be highly appreciated.

[pjft]

Thanks for this.

I read the code and added a few remarks, as I am not especially familiar with this part of the code so the side effects aren't clear.

[benjdero]

@pjft Thanks for the input. I think this also need more testing to get feedback from designers and users, there is a few points that I'm not sure about, for example:

• Currently there is no sound played when switching system using the quick system switch, maybe this could play the scroll sound, or the scroll sound from the system view but then I would have to do a "small hack" to get the scroll sound of system view inside the game list view.
• Using the "launch" and "back" sounds for going in and out of a folder seems a bit weird, especially with the "launch" sound I used in my test theme, maybe this should use the "scroll" sound as it is the same kind of navigation event.
• ...

[cmitu]

I agree with @pjft about keeping the existing scrollSound element - backwards compatibility matters, especially for themes which will are no longer updated.

Personally, I don't see the need for the back sound, either from exiting a system or a folder - and this might pose problems with fast system switching (which, as you remarked, is not implemented). Sounds for 'launch' and 'folder' enter should be separated - they're not the same function. Maybe use 'scroll' for folder entering/exiting ?

[benjdero]

@cmitu Maybe there is a little misunderstanding here:

• scrollSound is not meant to be removed, if there is a "global scroll sound" it is used first, and if there isn't then the scrollSound is used. Previous themes will still work. New Themes can choose to or not to get backward compatible with previous/other EmulationStation versions by adding the scrollSound on top of the "global scroll sound".
• The back sound is already used to exit a folder, I just changed it so it also play when you exit a system.

Beside that, I agree with you on fast system switch and scroll sound for folder entering (and maybe exiting but that would change behavior for older themes).

[benjdero]

@pjft @cmitu I rewrote my first post. Hope it's more clear like this.

[pjft]

Thanks.

For the suggestions, I agree that entering a folder should use the scroll sound instead. Undecided about the quick system select, to be honest, as I don't have a strong opinion either way.

[pjft]

From my end, I have no more comments from reading the code.

Given that the Theming part of the code is an area that @jrassa would be more familiar with, I'd definitely appreciate his or @tomaz82 's additional remarks.

[tomaz82]

This is an area of ES that I have not touched much, so I can't really give any input on this.

[jrassa]

I'll take a closer look and test soon, but it looks good to me.