Tomas R.

oops didn't notice you already fixed the conflict :sweat_smile:

Thanks for the review! (as always :D) I removed the `fix_title` implementation and used an enum instead of the `full_name` string as you suggested. The `bytestring_import` function should also be...

Thanks for the PR! > I've already pointed this out to @ThiefMaster. It's a validation issue, not really an accessibility issue. Can we do something about it in this PR?...

> Hmmm. I'm not sure we should support this case at all. See, for screenreaders, there's absolutely no difference between capital A and lowercase a. So even if I make...

> How elaborate do you want this algorithm to be? A more radical idea, but what if we just don't autocomplete? As in, we keep the behaviour of the current...

I noticed some differences from the old dropdown. Some of these might be nice to keep for the new one as well: - no results message:  - I'd keep...

> > no results message: > > It would take a lot of additional code to get this feature in. I think there isn't such a dramatic difference between saying...

> Ok. I've pushed a fix for the combobox widths. Right now, these controls use different implementations (number of extra slots uses SUI dropdown). My plan is to replace the...

Thanks! I have some more style nitpicks ;) - For disabled choices, I'd use the same lighter font color for the price as well (as it was previously). Previous: ...

Thanks again! > I think the default height could be a bit larger. Currently it fits only 4 choices, which makes it feel a bit cramped Much better now! Do...