Tomas R. comments

Results 176 comments of


                                            Tomas R.

Add instructions for setting up ruby and sass

Indeed, this is about settting up the website, not cpython ;)

Add instructions for setting up ruby and sass

The looks to be resolved by #2623 and #2619 :)

gh-125756: Document `Pickler.clear_memo`

> I hope you fix the problems with clear_memo before making this doc public Did you read my comment about it on the original isue? Sorry for the late reply,...

gh-116022: Improve `repr()` of AST nodes

Thanks for taking a look! > I think your approach makes sense If you had a different approach in mind, I'm happy to change it. This is what makes sense...

gh-116022: Improve `repr()` of AST nodes

Sorry it took so long :sweat_smile: I think I finally addressed all of the comments :)

gh-116022: Improve `repr()` of AST nodes

I moved the tests to a separate data folder and added a CLI toggle to automatically regenerate them with `./python Lib/test/test_ast.py --snapshot-update`. This is basically snapshot testing similar to how...

gh-116022: Improve `repr()` of AST nodes

^ fixed the conflicts in tests

gh-116022: Improve `repr()` of AST nodes

> There's some CI failure that looks like something needs to be tweaked in relation to the new file. Thanks for pointing that out, should be fixed now :)

gh-116022: Improve `repr()` of AST nodes

Thanks @JelleZijlstra and everyone else for reviews and help on getting this done!

python versions of bisect_right and bisect_left can fail guarantees

I think neither the Python nor the C implementation are actually meant to work with a negative `hi` argument. The C implementation does special case `hi == -1` but that's...