Tomas R.

Results 176 comments of Tomas R.

^ We've discussed this with @micsucmed yesterday. Unfortunately it doesn't seem that easy to do :confused:

I learned about this from the "core.py" podcast and it sounds like a great idea! I'd be happy help with this effort :)

Agreed, but from my understanding that is currently the case with `VariableExpression` and `LiteralExpression` anyway. You need to inspect the annotation to know if you're dealing with an unsupported expression....

> Good catch. In which case I'd argue those should be reworked to match this one, not the other way around. 😉 Indeed, that would be better :) In that...

It seems that Ctrl+← is converted into `ctrl left` which is treated as an invalid character (same for Ctrl+→). Not sure how to represent this key combination in the keymap...

hmm looks like an encoding issue. Hopefully, this'll fix it.

No worries! luckily I have a windows machine lying around 😅 The problem is that there's no way to specify the output encoding so it uses the platform default. This...

> Thanks! Thanks for the review!

I also added a `--snapshot-update` CLI argument to make it easy to regenerate the snapshots (as is already the case with some ast and recently argparse tests)

> Additionally, I think use of resolve_qualified_name might be helpful in your implementation: I thought there might be something like this already, but couldn't find it. Thanks!