Tomas R.

Results 176 comments of Tomas R.

> > I'm not a fan of renaming these columns to "Full name"... it's overly verbose. > > What would you suggest for the names of participants on "Participant roles"...

Depending on how we generate the SBOM, we might also be able to ship it with our wheels using [PEP770](https://peps.python.org/pep-0770/)

I like the flexibility to link anything, especially given the fact that currently the rules of what can and cannot be linked are not spelled out anywhere which leaves users...

Bisected to https://github.com/python/cpython/pull/107320 so confirming that it's related to `iterdir()` and not the generator itself.

> Why the new checker is not added to babel/messages/checkers.py? Yeah, that might be a good idea. I'll look into that :)

Perhaps it might make more sense to start with implementing the [`python-brace-format` flag](https://github.com/python-babel/babel/issues/333)

Here's a smaller reproducer: ```python import io from babel.messages.pofile import read_po po = io.StringIO('msgid ""') read_po(po) ``` Neither is a valid PO file so we should ideally raise a `PoFileError`...

I think checking if `self.translations` is empty inside `_finish_current_message()` and raising a `PoFileError` if that's the case might work. In any case, feel free to ask if you need help...

Right, there's this `abort_invalid` flag. I guess if it's set to `True`, we should just raise, and if not maybe we could insert a dummy translation, something like `(0, '')`...

To be honest, I'm not that familiar with the parser code either, but I think you are right. We should only raise/warn when we call `_finish_current_message` while `self.messages` is not...