Tomas R.
Tomas R.
Thanks for the PR! Do you think you could add some tests for this fix? Somewhere here might be a good place: https://github.com/python-babel/babel/blob/313277af993cebfbae49d385327fc7f45e32f737/tests/test_dates.py#L715-L720
Wow that's higher than I would think! But yeah I agree, let's wait a bit
Nice! The only issue I see is the gettext implementation. It is possible that the message you are looking for is pluralized in which case you have to look at...
Seems to be an issue with how the obsolete mesages are parsed: https://github.com/python-babel/babel/blob/f91754b01cb9f32b83aeaa80b74ed10b5dfccb6a/babel/messages/pofile.py#L240-L242 The above looks to only be using the msgid, rather than `(msgid, msgctx)`, so messages with the...
@akx Let me know if this is worth fixing, happy to send a PR :)
> We should also probably add more smoke tests to test all of the CLDR presets..? That would definitely be nice! I bet there are a lot of surprises lurking...
> Hrm, can't we just pass a custom wrapper to the document templates? I don't want to make the core APIs uglier because of this ;x One danger of that...
> I see your point. Possibly a breakpoint before the title with higher priority would help here. I don't think we have that kind of granularity, we're using a combination...
Yeah pretty much, I'd prefer to only show bookings you can actually link
> in the event's date interval FWIW we might want to relax the overlap rules for when a booking can be linked to an event, but that can be done...