Tobias Löfstrand

Results 51 comments of Tobias Löfstrand

> @tolo I'm not sure I understand the point of this PR. `router.go('/branchA');` already works. Why would a number in the URL be desirable ( when you consider the web...

> instead of using index, have you thought about using name instead? i.e a new name parameter to StatefulShellRouteBranch. and then you can use reuse goName API Good suggestion. Name...

Added some generalization and simplification around both the path based redirects and the API in general. Will update the PR description to reflect these changes after the weekend.

Decided to narrow the focus of this PR to mainly adress the goBranch API as well as introducing improvements around the ShellRoute/StatefulShellRoute API in general. Will update name and description...

@chunhtai / @hannah-hyj, when you have a minute, I'd appreciate you're thoughts around this.

> I know I have been slacking off at this pr. I am sorry about this. My schedule is quite tight after I came back from vacation. This is still...

> What's the status here ? It seems like you said that you have a test locally that's failing but it's unrelated to the changes here ? Yes, @chunhtai, have...

@chunhtai, as mentioned above, I've included the fix for cleaning obsolete branches. But I'm thinking it might be better to postpone that fix until the issues with duplicate GlobalKeys is...

FYI, for those interested in `StatefulShellRoute` evolution, there is a related (draft) PR in the works: flutter/packages#7622. There are some ideas around quality-of-life improvements around StatefulShellRoute in there, so have...

This issues is simply caused by the anti-pattern of creating (and recreating) the GoRouter inline inside the build method. Compare it for instance to how you wouldn't create objects like...