Tobias Löfstrand

> 1. The documentation for the `builder` and `pageBuilder` fields of `ShellRoute` (now moved to `ShellRouteBase`) says that the child argument of the builder will be the Widget built by...

> I left some comments on the top level API, I have not look into details yet. Great feedback, thanks! And I think you may be right in that the...

> It doesn't need to be a RouteBase subclass, it can just be a wrapper of route class to let StatefulShellRoute understand the navigator key to subroute relation. Yes, I...

Ok, so I pushed another iteration. `PartitionedShellRoute` is now refactored and renamed to `StatefulShellRoute`, pretty much like as described above. There are two constructors, one that accepts a list of...

> in this case you can't use Navigator since it requires a parent with defined height/width Interesting, not something I've run into or considered. Anyway, this feels a bit out...

Trying to decide which constructor(s) leads to the best API for `StatefulShellRoute`. Right now I have three candidates, and I’d love some feedback here. Perhaps there could be more than...

> Would it not make more sense to pass down the children in the `StatefulShellRoute.builder`? Then the children could be put into a `PageView` or even a `TabView` and then...

> 1. Add a "`branchContainerBuilder`" to `StatefulShellRoute`, as an alternative to `builder`, to be able to customize the container for the navigation branches (i.e. instead of using an `IndexedStack`). >...

> Refining things a bit now, to clarify and to avoid unnecessary code being run (when choosing not to use the default IndexedStack). Updated documentation and added some refinements around...

Perhaps not strictly related to the main topic (and perhaps more of a clarification), but it was brought to my attention that the sample code (`stateful_nested_navigation.dart`) uses two nested Scaffolds,...