Tobias Löfstrand

Seems to be some UX glitch in GitHub with re-requesting reviews (or perhaps it's just me 😂), but anyway @chunhtai and @bizz84, would appreciate a re-review.

>It was just possible to add routers and ShellRoute to the list earlier, because they inherited from RouteBase. And now StatefulShellRoute has only the GoRoute type. Actually, the default constructor...

> Would it also be possible to add the `ShellRouteState` to the `StatefulShellRoute`'s builder? This way I think we can provide a good solution for supporting better animation options. It's...

> Only it results in the following error: > > ``` > Unhandled Exception: 'package:go_router/src/route.dart': Failed assertion: line 630 pos 16: 'route.parentNavigatorKey == null || route.parentNavigatorKey == branches[i].navigatorKey': is not...

> My apologies not sure what happend before but indeed when I ran the example again today it provided me with the error of duplicate names. Also updated my example...

Instead of attempting to save and restore state, would it be an option to build a solution where a nested GoRouter object is used to preserve a navigation stack, while...

Yeah, I think I have stumbled over that issue before, and I agree that a state restoration based solution could possibly be used as a clean way of supporting "persistent"...

I've made an attempt of addressing this issue, by introducing a new `ShellRoute` subclass, called `NestedNavigationShellRoute` (see [this fork/branch](https://github.com/tolo/flutter_packages/tree/nested-persistent-navigation/packages/go_router)). Using that route class, you can delegate handling of nested navigation...

Thanks @lucavenir, sorry for the late reply! I'm afraid introducing a new API is necessary, to be able to support multiple Navigators for a shell route, as well as the...

So sorry for the extremely late reply, mail got buried in the inbox...🤦‍♂️ Thanks a bunch anyway for sharing your findings, will add this information to the readme! Cheers!