Yewen Fan

haha, thanks @jdramsey ! :) I am Yewen Fan :)

btw, could you update your description to contain more details on the bug you fixed? We should write a better descriptions in general (i.e. for every possible PRs) for people...

Yeah, I share the same concern as Joe. Could you please ask the owner (or whoever familiar with the code) about the context why we need "if self.existOnePathWithPossibleParents(previous, node_r, node_x,...

@zhi-yi-huang any updates regarding this PR? :) Sorry for the late reply though hhhh

Hi Andrew, Thanks so much for your input! We really appreciate it. Currently we are working on "code quality improvement project", and we will fix this issue during the project....

Hi Andrew, Thanks for the clear explanation! Yeah, it seems in your use case, you need the remove_node() to behave functionally. 1. Regarding your first comment, I am wondering why...

Hi Andrew, 1. I briefly googled "violation of faithfulness because of deterministic relations", and found https://arxiv.org/pdf/2010.14265.pdf, which states "This assumption can, however, be violated in many ways, including xor connections,...

Hi Andrew, I'd like to help, but I am also relatively new to causal discovery (I just started my PhD last August, and my first year project is not very...

Hi @delacylab, Thanks for researching, and finding the root cause. Do you mind adding an assertion in our codebase to ensure the matrix is not singular before calling inverse? In...

Thanks @ErdunGAO for your awesome work! Could you update your description to be more descriptive? (i.e. what bugs you fixed, what changes you made etc.) And by looking at code...