causal-learn icon indicating copy to clipboard operation
causal-learn copied to clipboard

Adding auto test for PNL

Open ErdunGAO opened this issue 2 years ago • 2 comments

Updates

  • Clean some useless codes
  1. The MixGuaussian layer is replaced by using MLP.
  2. Clean the print and plot functions for debugging.
  3. Clean the normalization function.
  • Correct errors.
  1. Correct the error in calculating the Jacob.
  • Add an abnormal points deletion function for data pre-processing.
  • Add the test file for PNL.

Test plan

python -m unittest TestPNL.py # should pass

image

TODO

  • Optimize the codes to run faster.
  • Add the test for real data (At present, the performance on real data is unsatisfactory.).

ErdunGAO avatar Sep 08 '22 07:09 ErdunGAO

Thanks @ErdunGAO for your awesome work!

Could you update your description to be more descriptive? (i.e. what bugs you fixed, what changes you made etc.)

And by looking at code --- it seems you changed lots of logic. Why? Is it because our previous implementation may have some errors?

And I still remembered you said the current version doesn't work for real data, is it still the case? Are we trying to fix this issue? :)

tofuwen avatar Sep 16 '22 02:09 tofuwen

Thanks @ErdunGAO for your awesome work!

Could you update your description to be more descriptive? (i.e. what bugs you fixed, what changes you made etc.)

And by looking at code --- it seems you changed lots of logic. Why? Is it because our previous implementation may have some errors?

And I still remembered you said the current version doesn't work for real data, is it still the case? Are we trying to fix this issue? :)

Sorry for the late reply @tofuwen.

I will add more detailed descriptions for this new request. This will be finished in the coming one or two days.

Actually, I just cleared some useless codes, e.g., debugging output lines and the useless Gaussian mixture function, and added an outlier points deletion function. The model parameters were also updated to perform better.

For the real data case, our method works (distinguish the cause and effect) but the performance is not good. Yes, I am working on this issue.

ErdunGAO avatar Sep 19 '22 12:09 ErdunGAO