Yewen Fan

Yes, I totally agree. The problem is: our codebase in not designed in a OOP manner. The algorithms should extend the same base class, and the base class should have...

Totally agree!! :) More tests, the better! (Learned this lesson in a hard way lol)

Thanks for reporting! This is very helpful! cc @MarkDana @aoqiz to take a look. Currently we are also aware that KCI may have problem (because we are adding tests to...

Hi @cogito233, I checked with expert. Our KCI code is translated from Kun [who is the first author of KCI]'s original matlab code (http://people.tuebingen.mpg.de/kzhang/KCI-test.zip), do you mind running your example...

Hey @aoqiz, could you take a look at this issue, since you fixed a KCI bug? I guess it's related?

Hi @delacylab, Thanks so much for taking the time to debug and implement. I am also aware of this issue, but our current codebase lacks tests, and I am afraid...

Hi @delacylab, Thanks so much for your help! Yeah, if possible, you can change all of these files. We will have review to make sure your changes won't break anything...

Hi @delacylab, Thanks so much for your help! :) No worry, we will take a look. Hi @chenweiDelight, do you mind taking a look at @jdramsey's question?

@chenweiDelight @zhi-yi-huang It seems https://github.com/cmu-phil/causal-learn/issues/54 is related. Do you mind taking a look and provide some context so we can fix? Currently remove_edge seems O(n^2), which is too slow, and...

Hi @jdramsey and @bja43, after discussed with Kun, we think this is really needed and a great feature we should support. I am wondering whether @bja43 can contribute your code...