Toshimasa Nasu

Results 6 comments of Toshimasa Nasu

Unable to disable default java_package_prefix with managed mode

Hi, I want to use the reverse domain of "xxx.co.jp". I'd like to simply generate codes with the proto package below: * proto ``` syntax = "proto3"; package jp.co.xxx; ......

Custom abci interface to extended Tendermint abci interface

@ulbqb Do you mean that our change should only be adding services (and requests/responses) in the ABCI interface? I agree with your proposal since we were taking a lot of...

Fix the test case that often fails.

I met the `TestByzantinePrevoteEquivocation` which is often failing. But I never met the other two. However, I met the `TestWALCrash` which is often failing. I've just addressed two test cases(PR:https://github.com/line/ostracon/pull/319):...

Fix the test case that often fails.

Recent errors: * Should be re-run ``` --- FAIL: TestProposerFrequency (7.64s) --- FAIL: TestStateBadVoterWithSelectedVoter (0.98s) --- FAIL: TestSelectVoter (0.01s) voter_set_test.go:311: Error Trace: /home/runner/work/ostracon/ostracon/types/voter_set_test.go:311 Error: Should be true Test: TestSelectVoter ```...

Fix the test case that often fails.

Recent errors: ``` --- FAIL: TestLightClientAttackEvidence_Equivocation (1.10s) detector_test.go:115: ==> verification sequential detector_test.go:181: Error Trace: /home/runner/work/ostracon/ostracon/light/detector_test.go:181 Error: Should be true Test: TestLightClientAttackEvidence_Equivocation detector_test.go:190: Error Trace: /home/runner/work/ostracon/ostracon/light/detector_test.go:190 Error: Should be true Test:...

Need to replace tendermint/tendermint to cometbft/cometbft

@tkxkd0159 What are the discussion points? I think we should follow `cometbft/cometbft` as well. Basically, we forked/followed-up the based on `tendermint-v0.34.19`. It means the compatibility between `cometbft` and `ostracon`. It's...