ostracon icon indicating copy to clipboard operation
ostracon copied to clipboard

Need to replace tendermint/tendermint to cometbft/cometbft

Open tkxkd0159 opened this issue 2 years ago • 3 comments

Summary

ref. https://github.com/tendermint/tendermint/issues/9972

Problem Definition

Proposal


For Admin Use

  • [x] Not duplicate issue
  • [x] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

tkxkd0159 avatar Feb 02 '23 07:02 tkxkd0159

There has been an official announcement to switch from Tendermint Core to CometBFT. This includes changes to Tendermint peripheral modules, such as tm-dbcometbft-db. Future Ostracon should also consider plans to change its codebase to CometBFT. https://github.com/cometbft/cometbft https://medium.com/the-interchain-foundation/cosmos-meet-cometbft-d89f5dce60dd

This task may be tracked after the current project phase.

torao avatar Feb 03 '23 05:02 torao

@tkxkd0159 What are the discussion points? I think we should follow cometbft/cometbft as well. Basically, we forked/followed-up the based on tendermint-v0.34.19. It means the compatibility between cometbft and ostracon. It's possible to replace the below:

  • Replace tendermint/tendermint to cometbft/cometbft in go.mod
  • Replace tendermint/tm-db to cometbft/cometbft-db in go.mod

tnasu avatar Feb 03 '23 09:02 tnasu

@tnasu Sorry I missed this alarm. I just evoked the surroundings to make this change. So there is no point in discussion.

tkxkd0159 avatar Feb 15 '23 14:02 tkxkd0159