Tianyu Li

Results 19 comments of Tianyu Li

There are still failures, I will fix this concurrently with review.

There is a bunch of Set methods in SettingsManager. I don't know how they interact with transactions though.

I think it is still failing on Travis last I checked (Your PR) Maybe we should disable this for now?

Temporarily fixed due to #1450, we should re-enable dependency when possible.

@lmwnshn There seems to be a lot of refactors in this PR not necessarily related to sequences. We can probably get those into a separate PR and merge those immediately.

@pervazea Can you take a look since these other people are out of town?

Right now we are not actually testing anything in update_test due to the lack of assertions. We should change the printout messages to actually check results. (Then replace LOG_DEBUG for...

After talking to @ChTimTsubasa it seems like Postgres does this as well so we don't have to invalidate plan on an interleaving like this: thread1: plan thread1: bind thread2: drop...

Who is currently responsible for merging this in? Are code reviews here outdated or still being addressed?

Should we cherry-pick that commit and merge or is it fine to leave this until #1435 gets in?