peloton icon indicating copy to clipboard operation
peloton copied to clipboard

Add assertions and remove LOG_INFO from update_test

Open apavlo opened this issue 7 years ago • 2 comments

There is a bunch of LOG_INFO debug statements in 'update_test.cpp'

https://github.com/cmu-db/peloton/blob/master/test/executor/update_test.cpp

We should replace them to LOG_DEBUG. This should be easy

apavlo avatar May 31 '18 23:05 apavlo

I am new to this . I changed what you asked for here : https://github.com/cmu-db/peloton/compare/master...Traveler98:patch-1 Hope I've done it right . EDIT : I've made a pull request too .

Traveler98 avatar Jun 07 '18 14:06 Traveler98

Right now we are not actually testing anything in update_test due to the lack of assertions. We should change the printout messages to actually check results.

(Then replace LOG_DEBUG for whatever printout is left)

tli2 avatar Jun 07 '18 21:06 tli2