Tronje Krop

Results 65 comments of Tronje Krop

@gayanper thanks for the PR. I'm not sure what this feature is about. Can you explain your exact use case and what additional references are made available here?

@shaburov Sorry, the year. I'm actually only waiting for the initiator to add the security switch to turn this feature on and off as a safeguard. If you are willing...

May be fixed by #307, however this has a political aspect that currently prevents merging. See https://github.com/zalando/intellij-swagger/pull/307#pullrequestreview-413347642.

I'm not absolutely sure about what a performance test would bring here. Primarily it would measure buffer to I/O copying. What should it be compared against, and what should a...

> Against not using logbook. Users should have a clue how big the penalty is. Does not really make sense in my opinion, especially as logbook provides many customization switches...

@antonu17 I like this very simple suggestion. It actually would solve a challenge running behind `ngnix` for me too. Sad, that it has not been merged.

But is there something missing to make the test effective?

I have to correct my before statement. Looking into https://app.codecov.io/gh/zalando/tokens/compare/223/changes shows, that there should by no coverage difference.