Tronje Krop
Tronje Krop
Sorry for missing to answer timely. Yes, this is a mistake. We should have implemented the rule more general to allow customizing the domain used for the functional host name....
Can you provide the pull request?
Since we do not support API Key Authorization in Zalando and it is not part of our [API Guidelines](https://opensource.zalando.com/restful-api-guidelines/), we have no need to implement this rule. However, we would...
Have you considered to use a `WaitGroup` as described in https://medium.com/@poy/gomock-and-go-routines-6a7c01d989d5 for signalling completion. I know it is actually a bit more difficult since you also need to unlock your...
My two cents on this: * Adding pagination would break existing clients, so it is no option. * Removing the description would not be sufficient for the Sunrise import process....
I'm a bit hesitant to approve this, because the pull request majorly splits up the dense description from before into 4 subsections without providing additional clarification that wasn't clear from...
@ePaul I agree, but changing the design of a rule in Zally is not that simple. We need to analyze how this observation can be best expressed with the current...
A general explanation without looking at the details of the example here: A Zally *violation* is following a specific concept: it belongs to a *rule* and fails on a specific...