Timo Kluck

Results 37 comments of Timo Kluck

Thanks for the detailed thoughts @essenciary ! To start with your > Can we make dependencies on external parsers (HAML, Mustache, etc) optional? (Probably not without Pkg warnings like "Genie...

I'll be happy to send a pull request. Hopefully I'll find time over the weekend :) As for integrating using Requires.jl: for now it's probably a better idea if I...

That's really cool @essenciary ! I can't promise at the moment when I'll have time, but I'll do this as soon as I can divert some attention to HAML.jl. Would...

I just added a compatibility method to `HAML.jl` here: https://github.com/tkluck/HAML.jl/blob/master/src/Genie.jl With this approach, the user just imports ```julia import HAML.GenieTools: html ``` and uses that in their controller just as...

> Cause otherwise you need to add Genie as a dependency for HAML.jl which is overkill. I prevented that by using [`Requires.jl`](https://github.com/MikeInnes/Requires.jl) which only loads the compatibility code when `Genie`...

I ran into a similar issue, and traced it down to the following. The tutorial gives this line of code: julia> correct_prediction = indmax(y,2) .== indmax(y_, 2) false But as...

Thanks for the report. There's two parts to this: - The source file `matmul.jl` really isn't available on your system which is why StatProfilerHTML can't generate that part of the...

That sounds really useful! I'm open to pull requests here.

Thanks for highlighting the issue and it seems worth fixing. I'm not sure I'm convinced we should fix it by adding a regex parameter; is there a more direct way...

I was thinking maybe we can unify it with the `from_c` filter that we already have, so that's somewhere around here: https://github.com/tkluck/StatProfilerHTML.jl/blob/master/src/Reports.jl#L99 I also think some people might be interested...