TJ Mahr

Results 21 comments of TJ Mahr

What's the point of the butterfly shape, as opposed to a ribbon? I don't think the bin boundaries are working correctly. First one straddles 0 and last one do not...

Aah shoot, that last figure has 33 bins because of how 129 was being rounded. General problem still stands.

We want it to be exported. It could use documentation.

Or make their own custom plots. The idea is that each bayesplot function does two things. 1. Prepares the MCMC or PPC draws for plotting with ggplot2 by creating a...

greta does something like this. https://greta-stats.org/articles/get_started.html#plotting ![image](https://user-images.githubusercontent.com/1890315/57943570-f6f39a00-7899-11e9-85db-fce9663cb129.png) But I don't know how its DAG building is implemented, but the plotting uses [DiagrammeR](http://rich-iannone.github.io/DiagrammeR/graphviz_and_mermaid.html). I've used to DiagrammeR convert lavaan SEM models...

> Helper functions sound great. > What you wrote the other year for changing the legend strings was: > > p$scales$scales[[1]]$labels p$scales$scales[[2]]$labels > This happens after the plot is already...

@jgabry would the generics go in rstantools and the S3 methods go into rstan and rstanarm? I'm not sure about the stanverse organization in this regard.

Let's wait and see what happens here https://github.com/tidyverse/ggplot2/pull/2749 where the ggplot2 authors are sorting out how to make default aesthetics customizable with a plotting theme.

Hmm, we could export our colorizers. ``` library(bayesplot) library(ggplot2) y

waldo::compare() has two parameters that mention environments. Does that help? We could build the plots and compare them. That would add plot building to the test timing.