Tit Petric

Results 111 comments of Tit Petric

Just a note for future travellers: - if you're doing something like `go test ./...` it will continue with all package tests even if one of them fails to compile...

@letzya this is a bit old, can you please file a jira ticket and raise it with @andyo-tyk, thanks

It's unfortunate that a sliding log implementation is in use here, but recent versions allow you to consider using a fixed window rate limiter behaviour and this performance/resource usage penalty...

Sonarcloud issue refers to https://github.com/dominikh/go-tools/issues/1336 Stdlib provides a BufferPool interface which can't satisfy SA6002. Due to the nature/area of the usage, I believe this can be ignored, as these are...

I love the experiment, the only thing I'm missing is an allow-list style configuration of what urls the experiment is allowed to fetch from at this moment. This would allow...

@coreydaley Let me know if there's absolutely anything I can do to improve it. I've considered adding a .SetRegexpCompile(func(...)...) as an API addition, but wen't with the 'less is more'...

> Another note - all of the changes from this PR seem to also be present in #732 Correct, regexp is it's own optimization scope (this PR). The second PR...