tyk icon indicating copy to clipboard operation
tyk copied to clipboard

Fix data race over log, move to init() to avoid mutex lock

Open titpetric opened this issue 2 years ago • 2 comments

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • [ ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own fork, don't request your master!
  • [ ] Make sure you are making a pull request against the master branch (left side). Also, you should start your branch off our latest master.
  • [ ] My change requires a change to the documentation.
    • [ ] If you've changed APIs, describe what needs to be updated in the documentation.
    • [ ] If new config option added, ensure that it can be set via ENV variable
  • [ ] I have updated the documentation accordingly.
  • [ ] Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • [ ] When updating library version must provide reason/explanation for this update.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] Check your code additions will not fail linting checks:
    • [ ] go fmt -s
    • [ ] go vet

titpetric avatar Aug 26 '22 07:08 titpetric

API tests result: success :white_check_mark: Branch used: refs/pull/4270/merge Commit:
Triggered by: pull_request (@titpetric) Execution page

Tyk-ITS avatar Aug 26 '22 07:08 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/4270/merge Commit: 2559701f3029f40ae8858e29fcb4cdea0ce244f9 Triggered by: pull_request (@titpetric) Execution page

Tyk-ITS avatar Jan 10 '23 09:01 Tyk-ITS

/release to release-4-lts

titpetric avatar Jan 10 '23 09:01 titpetric

Working on it! Note that it can take a few minutes.

tykbot[bot] avatar Jan 10 '23 09:01 tykbot[bot]

@titpetric Succesfully merged PR

tykbot[bot] avatar Jan 10 '23 09:01 tykbot[bot]

/release to release-4

titpetric avatar Jan 10 '23 09:01 titpetric

Working on it! Note that it can take a few minutes.

tykbot[bot] avatar Jan 10 '23 09:01 tykbot[bot]

@titpetric Succesfully merged PR

tykbot[bot] avatar Jan 10 '23 09:01 tykbot[bot]

/release to release-4.3

titpetric avatar Jan 10 '23 09:01 titpetric

Working on it! Note that it can take a few minutes.

tykbot[bot] avatar Jan 10 '23 09:01 tykbot[bot]

@titpetric Succesfully merged PR

tykbot[bot] avatar Jan 10 '23 09:01 tykbot[bot]