Tit Petric

Results 146 comments of Tit Petric

Hey @padiazg, nice to see a contribution from your side. Could you please consider moving any extractable parts into subpackages of /internal? The PR: - extends internal apis - adds...

Good enough, would love a panic or error somewhere if that happens, as it should be an easy check to do.

Just reopening if this behaviour can be improved ...

@AlexVulaj thanks for #731 merge; rebased this one for review. Benchmark still the same as in description.

@coreydaley is there anything i can/should do to get this reviewed?

@apoorvajagtap took your suggestion, added test to cover the expectation of the error return contents, PTAL

This works (without the `|`), however, it doesn't report the times from the test output, but only how long it took to process the JSON: Example: ``` gotestsum --junitfile=unit-tests.xml --raw-command...

/release to release-4

/release to release-4-lts