Tit Petric
Tit Petric
I believe the tests on master have been resolved. Can I ask you for the hopefully last rebase? The teams are improving the test case failures, so your best case...
@PatrickTaibel I'm noticing this is used as the base of the following PR: https://github.com/TykTechnologies/tyk/pull/3979 - can you please include those changes here, and close that PR?
My mistake, it seemed like a patch of this one. Will do housekeeping there too, thanks :)
> In case people rely on the behaviour of the current prefixed textformatter, the usage patters will change due to the significantly different output here. If you want to filter...
@buger Logrus has a syslog hook, which is used to stream log data to syslog and I asumed elastic too, as it has a syslog ingress. These are not impacted....
I've rechecked the prefixed formatter, it's only available with a TTY, an interactive terminal. Do we somewhere make some explicit guarantees about output formatting? What would acceptance criteria here be,...
@PatrickTaibel we discussed having a particular match for the length regexp `/{[0-9]+(,[0-9]+)}/`, to keep that regex fragment as-is, and not apply matching for gorilla/mux-like /{id} patterns in such a case....
I think this may be a problematic change for some people that use custom response writers, or wrap them incompletely (as per godoc). Please add error handling that confirms implementation.
@matiasinsaurralde hey, would you be so kind to review. I added the test cases for the coprocess bindings, and fixed a flaky test in the process (race condition when connecting...
cc @ermirizio @buger I'm asuming the referenced PR above is going to be orphaned and/or somebody needs to pick up this. I am/was happy with my proposed diff here, but...