tison

Results 962 comments of tison

Well. After #430 merged the test added in this patch failed. Need a closer look.

I adjust the test to inject force `reset`s instead of depending on connection loss. Although this means it should be a non-real-world case now, I still agree on `setLeadership(false)` on...

@XComp Thank you very much for the comments. Could you send a pull request based on the current patch? I don't know whether I can directly merge on the forked...

> but couldn't base it onto this PR Actually, you can send a pull request with base branch = https://github.com/woaishixiaoxiao/curator/tree/fixbug/LeaderLatch-double-master and head branch = your branch :) Then the pull...

@XComp OK. After looking into the patch I think #436 is better to proceed (you made a significant diff :)). I'll try to take a look this wek.

@martin-g code conflict. If you'd like to move forward this effort, please rebase the commits so that I can give a review.

It seems tests failed steadily.

Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant.

Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. BTW, `NodeCache` and `PathChildrenCache` are deprecated...

Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant.