tison comments

Results 962 comments of


                                            tison

[CURATOR-565] check useContainerParentsIfAvailable for ExistsBuilderImpl.

Closed as stale. Feel free to resubmit it if you're still willing to proceed.

Build on jdk Set release target to 8 for jdk11 compiler

We already build for JDK8 and JDK11 on master.

CURATOR-373 Add option to PersistentNode to not overwrite/delete existing node

Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant.

[CURATOR-535] TestServer random port selection has a race condition

Since this patch doesn't resolve the problem, I tend not to merge such change. Perhaps @eolivelli @Randgalt have different ideas.

LeaderSelector mutex resurrection

Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant.

CURATOR-235 LeaderSelector.internalRequeue should be private

This is on the master https://github.com/apache/curator/commit/0bec8a066f8a4b5d26ef3621800543a54b46ac3e. But it's from another author. Sorry that we don't properly link the PR and specify credit.

A fix for double barrier timeout behavior, and an accompanying test

Closed as inactive. Feel free to create a JIRA ticket and resubmit this patch.

initial BasicAuthExhibitorRestClient

Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant.

CURATOR-653: fix potential double leader for LeaderLatch

LGTM. I also think of this change days before. cc @eolivelli @Randgalt can you also give a review?

CURATOR-653: fix potential double leader for LeaderLatch

@woaishixiaoxiao can you create a JIRA ticket on https://issues.apache.org/jira/projects/CURATOR for this patch?