curator
curator copied to clipboard
Test with JDK 17. Update Mockito and JUnit 5.x
Continuation of #407
I will rebase it to master
once #407 is merged!
https://github.com/apache/curator/pull/410/commits/f6bac3372130882ee1991b087283842f542474ad "fixes" the problem in org.apache.curator.framework.imps.GzipCompressionProvider but it does not look nice. I'd recommend a deeper look here!
Now the build on JDK 17 fails due to Jersey. https://github.com/apache/curator/blob/fe50da4904aa4ca4f51b473ad298ae664358ff3c/pom.xml#L84-L86 says that it is not worth it to upgrade.
I am +1 to upgrading Jersey. That comment (https://stackoverflow.com/questions/17098341#22033825) is very old.
Also I am not sure about why we are using Jersey in Curator... do you want to try to upgrade please ?
Also I am not sure about why we are using Jersey in Curator... do you want to try to upgrade please ?
It is used only in curator-x-discovery-server/src/test/java/org/apache/curator/x/discovery/server/jetty_jersey/TestMapsWithJersey.java
Is it valueable ? Should I try to upgrade it or just delete it ?
Is it valueable ? Should I try to upgrade it or just delete it ?
if we can keep the existing tests it is better, and it would be great to convert the test
that said, I am not sure about the real value of that test maybe @Randgalt or @cammckenzie know better than me.
I've updated Jersey to it latest 2.x version but there is still some problem - the MapDiscoveryContext is not seen as a @Provider
and org.apache.curator.x.discovery.server.jetty_jersey.MapDiscoveryResource
's constructor fails with a NPE. I'll try to debug it later.
@martin-g code conflict. If you'd like to move forward this effort, please rebase the commits so that I can give a review.
It seems tests failed steadily.