tison

Results 964 comments of tison

IIRC @zhongzc is the author of minitrace. Do you have some ideas we can move forward this issue? Otherwise, I'd prefer move this issue to Ideas until we found concrete...

* Remove next_column_id from TableInfo This seems not the case or we already resolved it? ```rust #[derive(Clone, Debug, PartialEq, Eq, Builder)] #[builder(pattern = "owned")] pub struct TableInfo { /// Id...

> due to the signature change Could you elaborate it a bit? From what to what, and why it breaks things ..

@waynexia Yeah I found the linked PR. It's a huge one and the related line seems: ```diff diff --git a/src/script/src/python/pyo3/builtins.rs b/src/script/src/python/pyo3/builtins.rs index 20d1c364415..6051a5307b9 100644 --- a/src/script/src/python/pyo3/builtins.rs +++ b/src/script/src/python/pyo3/builtins.rs @@ -90,7...

@J0HN50N133 Thanks for pushing forward this ticket! > pg_get_userbyid: it seems that user authentication is not supported in the open source codebase. Should I just return empty string? Yeah. This...

> The shortcomings is the potential incompatibility with existing pg eco. Yeah. Some how the type is different, but comparing should work. cc @killme2008 @waynexia what's the affect if we...

@suyanhanx Welcome! You're assigned and feel free to leave a comment here to share updates; or ping me as a reviewer if the patch is submitted.

To be clear, this issue is to add the option for self-building Docker image. It won't be integrated into our release workflow (or at least yet). The related file is:...

This issue reads quite generic. What is the concrete enhancement proposed?

This can cause a clippy failure (and perhaps further compiler error) as desc in https://github.com/PyO3/pyo3/issues/4094. But we need to release a new arrow version and bump the dep to arrow...