tison

Results 964 comments of tison

@orhun let's give this patch another time slice?

> Btw I also realized another thing, you can also get the same result with the following config This is a good workaround, unless we have too many tags to...

@orhun Your suggestion sounds good. Let me try to update the document for `count_tags` and make this a mergable patch.

I come back that https://github.com/GreptimeTeam/greptimedb/pull/4379 shows invert the logics and trying to exclude tags is hard. It's quite straightforward that I'd "include" only one tag. Let me update this patch...

I found `src/args.rs` now. Let me take a closer look.

@orhun Updated. Please take a look.

I don't know why "Check NodeJS tarball" failed. Doesn't seem like related to this patch.

@orhun master conflict. I merge and resolve that. Hopefully we can get a review in time to avoid further conflict.

https://github.com/orhun/git-cliff/actions/runs/10313078397/job/28549294078?pr=599 Seems unrelated? Or some integration tests setup issue I'm unfamiliar with.

ping @orhun any estimate this patch gets another review?