greptimedb
greptimedb copied to clipboard
Adopt span tracing in hot code path
What problem does the new feature solve?
Log and metrics are already integrated into our code base. Span tracing is another tool to further improve observability. We can start the adoption from insert/query/server modules first.
What does the feature do?
Add tracing::instrument
to some critical paths
Implementation challenges
No response
Important notes about tracing
crate:
- It's not stable yet
- It has relatively poor performance
- It's not fully compatible with opentelemetry libraries
Maybe minitrace is also a good choice.
IIRC @zhongzc is the author of minitrace. Do you have some ideas we can move forward this issue?
Otherwise, I'd prefer move this issue to Ideas until we found concrete work items.
We end up using tracing
to instrument the code for better integration with existing tracking-logging
infrastructure. But there are still some problems like post-sampling, multi-parent span etc.
there are still some problems like post-sampling, multi-parent span
This is precisely the realm of minitrace. If it is critical to the need, switching to minitrace is an option, and I would be happy to provide guidance on how to use it.