tison
... and https://github.com/jestjs/jest/issues/12221
Here is a monkey patch for fix: ```diff diff --git a/test/number-coercion-methods.spec.js b/test/number-coercion-methods.spec.js index af299e68d..81d03ee25 100644 --- a/test/number-coercion-methods.spec.js +++ b/test/number-coercion-methods.spec.js @@ -89,7 +89,10 @@ describe('number coercion methods', () => { );...
@jdalton Sounds like we should update the test to follow the expected manner. If so, I can apply the patch above for doing so.
Thanks for your contribution! LGTM. I'll wait a bit for CI and then merge if no blocker.
cppunit failure should be unrelated to this patch. Merging ...
@eolivelli @anmolnar @symat Please take a look.
> > we can remove the setter and change the static instance field to final. > > Agree with removing the setter > > * `private static MBeanRegistry instance =...
cc @maoling @eolivelli could you please take a look at this PR?
Today I have time to review this patch once more. And simplify the code to drop the redundant Holder class. @maoling @eolivelli would you take another look? I think it's...
@symat it seems jenkins failed on make c client module which is irrelevant to this commit. Could you take a look?