tison

Results 964 comments of tison

@briansmith ping as a reminder :D

@briansmith I suppose the codecov regression is false positive..

@briansmith is there other blocker to this PR?

@briansmith Thanks for your reply. I have one more question: > it is already clear which parts of the crate are covered by which license For a takeaway, are those...

Thanks a lot for the updates @briansmith! For ` crypto/mem.c`, I found `src/constant_time.rs` uses `CRYPTO_memcmp` also: ```rust /// Returns `Ok(())` if `a == b` and `Err(error::Unspecified)` otherwise. /// The comparison...

@asafm I ever talked about the stale bot, you can resume the discussion and I'm on the side to disable it. * https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp * https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls * https://lists.apache.org/thread/0woo9h53t109qsmtxsfqlcxzr16n5mn0 I may not...

Downstream reports - https://github.com/diffplug/spotless/issues/2046

FYI I implement it in the wrapper pattern at - https://github.com/GreptimeTeam/greptimedb/pull/3575 I feel that the implementation is possible to contribute back upstream so that we get it maintained and evolved...

Thanks for your feedback! I won't over commit it so I'll stop here. If I happen to have time make the change on the fst crate, I'll comment there. Then...

Seems this issue - https://stackoverflow.com/questions/59343675/javascript-jest-expect-0-equal-0