zookeeper icon indicating copy to clipboard operation
zookeeper copied to clipboard

Published 20 hours ago • verified publisher icon apache

ZOOKEEPER-3938: java client: upgrade jline from 2.x to 3.x and adapt Completer to the new API.

Open LiYvbo opened this issue 4 years ago • 6 comments

There are several Jline 3.x versions. I think it's time to adapt new version jlines. I made some adjustments to the 'JLineZNodeCompleter.java' in this pr.

the result is as follows. image

LiYvbo avatar Sep 17 '20 07:09 LiYvbo

@eolivelli Can you help me review my PR? And CI maven build failed, does it matter? I build the code without my commit and get the same test error.

LiYvbo avatar Sep 20 '20 02:09 LiYvbo

@symat it seems jenkins failed on make c client module which is irrelevant to this commit. Could you take a look?

tisonkun avatar Sep 20 '20 03:09 tisonkun

should be fix after https://github.com/apache/zookeeper/pull/1462

hanm avatar Sep 20 '20 05:09 hanm

What's the difference with #1461 ?

eolivelli avatar Sep 20 '20 07:09 eolivelli

What's the difference with #1461 ?

https://github.com/apache/zookeeper/pull/1461 is a draft. And this PR is not completely add jline license file. JLineZNodeCompleter is not used actually in the zkCli.

LiYvbo avatar Sep 20 '20 08:09 LiYvbo

@LiYvbo Was actually making the ZookeeperMain changes, I closed #1461 , since you have already made the changes. Thanks!

surnaik avatar Sep 20 '20 09:09 surnaik