Tim te Beek

hi! It's not immediately clear what you're proposing to contribute. Would this be a new recipe that reads the JavaDoc? We've had a recent proposal that perhaps comes close to...

You might be interested in this new recipe: - https://github.com/openrewrite/rewrite-migrate-java/pull/788#issuecomment-3200452153

Thanks for the report @jimbethancourt ! it looks to be failing on a `visitYield` inside `visitSwitchExpression`. Now we do have tests around the usage of `yield`, as seen here and...

That's odd; that field is not nullable, so then it's a bit unclear how it ended up being `null` here. https://github.com/openrewrite/rewrite-static-analysis/blob/ea97e582eb114c04bc7dc816d975770e5cec3189/src/main/java/org/openrewrite/staticanalysis/OperatorWrap.java#L179-L183 Those `instanceof` expressions are defined here. https://github.com/checkstyle/checkstyle/blob/3e5c4a85daff57a4364199119416cc44b932c0c0/src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/java19/InputRecordPatternsPreview.java#L30-L89 Likely we...

Also seen in PMD's [Jep440_RecordPatterns.java#L8-L75](https://github.com/pmd/pmd/blob/39f7a60c2b2f88c03181fafc6179d01f1260414f/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/ast/jdkversiontests/java21/Jep440_RecordPatterns.java#L8-L75) - https://github.com/openrewrite/rewrite-static-analysis/issues/631

@sambsnyd any quick thoughts on this? Seems in line with what we've validated before.

As a quick update: from the Java side we're now modeling the trailing comma as a marker; that might help here as well - https://github.com/openrewrite/rewrite/pull/4869

Thanks for the suggestion @blipper ! Indeed seems like something that could be worthwhile to detect and apply, especially when those other tools are present as well and might otherwise...

Linking some earlier comments on the older PR: - https://github.com/openrewrite/rewrite-kotlin/pull/626#issuecomment-2585471464 - https://github.com/openrewrite/rewrite-kotlin/pull/626#issuecomment-2585830207

So if I understand correctly you expect `ArtifactFactoryRequest.builder()` to be changed to just `builder()` ? If so I'd consider that extending what the recipe covers, but not a bug with...