Timo Stamm

Results 302 comments of Timo Stamm

Reminder for the implementation: Creating a message from a partial instance discards unknown fields. It must still be possible (and should be the default) to keep unknown fields in a...

After pondering this for a while, I think partial request inputs should simply be the default behavior. It adds a bit of a penalty because we will have to do...

This won't make it into 2.0 😞 The API change is non-breaking, so it should be good to add in a minor release.

Denis, are you sure you want to stringify the message directly? Why not use the [canonical JSON encoding](https://developers.google.com/protocol-buffers/docs/proto3#json) instead. `Response.toJsonString(response, {prettySpaces: 2})`.

Retries and file locking might make `@protobuf-ts/protoc` more difficult to maintain, so I'm a bit wary. In your case, I'd recommend downloading `protoc` _before_ executing it concurrently. If `protoc` is...

Got it. In that case, adding some functionality to `@protobuf-ts/protoc` might be the way to go. BTW, protobuf-ts uses lerna, which also runs things concurrently. `protoc` is simply installed early...

protobuf-ts takes the leading (and leading detached) comments for a JSDoc block: ```proto message PortSet { // It is extremely important that you do not use port 0 for this...

Thanks for your thoughts, @Zamiell. I think your `Fruit` example is about the worst case you could have, because none of the comments end up in JSDoc. What do you...

Thanks for the report, Ryan. To find a shared prefix, we convert the enum name to SCREAMING_SNAKE_CASE first, then test whether all value names have that prefix. But the conversion...

Thanks for bringing this up, @sachaw. I am happy to see that TypeScript will support Node.js 12's ESM additions. I wonder what that means for users of older TypeScript versions,...