Timo Stamm
Timo Stamm
True, we don't change enum value case - haven't considered that TBH. However: Following the [style guide](https://developers.google.com/protocol-buffers/docs/style#enums), you should use: ```proto enum Status { LAUNCHED = 1; INIT_GAME = 2;...
Thanks for your thoughts, @Zamiell. I _do_ agree that PascalCase fits well, and consistent naming rules are very nice to have. However, we need the original names for the JSON...
https://github.com/timostamm/protobuf-ts/commit/1a22444b7be39da9a5ad63819f3f1d0d4496f809 added the plugin option `eslint_disable`, and similar to ts_nocheck, it should become the default: > - "eslint_disable" Generate a eslint-disable comment at the top of each file. This will...
Thanks for the report and investigation! This confirms again that even the smallest feature requires overly diligent testing. Changed `UnknownMessage` from `type` to `interface` in v2.0.2.alpha-0`.
Now that looks interesting! If I remember correctly I was hesitant to omit the field names - in all other language implementations I am aware of, oneof members are siblings...
But I'm already attached :) The `oneofKind` discriminator always felt a bit like a workaround to me. I'd wager many users ask themselves why the discriminator is named that way...
Implementation notes. It's a long list, but many items will be trivial. **Runtime:** 1. Use intermediate type `{ oneofKind: ... , oneofValue: ... }` in `UnknownOneofGroup`, `isOneofGroup()` and the accessor...
> One thing that is confusing to me is why `oneofKindDiscriminator` is even an option that can be set for the interpreter. It also has some other options that can't...
> That's a bit unfortunate. For sure. From a [comment above](https://github.com/timostamm/protobuf-ts/issues/143#issuecomment-900103049 ): > It should be possible to look at all message fields, and only escape when just kind and...
Treating `null` the same as `undefined` as suggested seems like a good idea to me. It will be a type error because `PartialMessage` is typed for `undefined`, but it will...