Timo Stamm

Results 302 comments of Timo Stamm

Async functions are syntactic sugar for the Promise API. Returning a promise from an async function is the same as returning a promise in a `Promise.then()` callback - it will...

The text format is not implemented. Thank you for this link, though. This specification must have been added recently. This means it is finally possible to implement the text format...

This is not supported ATM. I was hoping for [proto3 optionals](https://github.com/timostamm/protobuf-ts/blob/master/MANUAL.md#proto3-optionals) to ultimately supersede `wrappers.proto`, as they have a nicer syntax in the IDL. That has not happened so far,...

I didn't do that to preserve method order, same with message fields. Having a plain array in the same order as the proto source is the best thing to have...

@Bluskript, reading this again I noticed that you can get away with a cast: ```ts const mi = Haberdasher.methods.find(m => m.name === "MakeHat") as MethodInfo; assert(mi !== undefined); const requests:...

Coincidentally, I just updated the code size benchmarks this morning, cleanup up the code as well. It's easy to measure code size, not so much the performance. For example, google-protobuf...

Thanks for the PR! The makefile bug from [this comment](https://github.com/timostamm/protobuf-ts/pull/124#issuecomment-868398656) is fixed in commit 326299f0335a0157d5c278369cf4e467809a1d53, making sure the performance benchmarks run with the same payload every time. Not saying benchmarks...

For reference: Large payload: 1.2MiB - FileDescriptorSet for `packages/test-fixtures/**/*.proto` Small payload: 49KiB - FileDescriptorSet just for `google/protobuf/descriptor.proto`

`ts-proto` uses protobuf.js for JSON, which doesn't fully the official JSON format, see protobufjs/protobuf.js#1304. I am sure they are skipping a few things. But look closely at the numbers. They...

I think the manual deserves a performance comparison table at the end of the section [Code size vs speed](https://github.com/timostamm/protobuf-ts/blob/master/MANUAL.md#code-size-vs-speed). It should just show numbers for binary I/O and JSON (string)...