Tim Jacomb

Results 1120 comments of Tim Jacomb
trafficstars

Hacked on it for an hour and it still doesn't run on my machine -.- But finally got geckodriver to start at least.

> Hacked on it for an hour and it still doesn't run on my machine -.- Turns out it ran find I just had a partially downloaded war 🙄. I...

Tests pass locally for me so hopefully updating to a new build sorts it

Sounds reasonable, happy to look at this on a pull request.

There was a pull request here which wouldn't take someone a lot of work to revive and get it merged: https://github.com/jenkinsci/configuration-as-code-plugin/pull/665

It's this which is tracked on the jenkins issue tracker: https://github.com/jenkinsci/jenkins/pull/4538 will try resolve conflicts when I get a chance

Resolved and build back to green and tests passing, hopefully it gets merged this time.

> HI, > > i would like to work on this. Sure, ask any questions here and just send a PR

> @timja would our validation that we add via #1121 give us a shorter error message ? Yes but we currently aren't validating before applying

error looks like you have an old ldap plugin