acceptance-test-harness icon indicating copy to clipboard operation
acceptance-test-harness copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Adapt changes to breadcrumbs accessibility

Open NotMyFault opened this issue 2 years ago • 3 comments

https://github.com/jenkinsci/jenkins/pull/6912

NotMyFault avatar Jul 25 '22 13:07 NotMyFault

cc @janfaracik

The current proposal introduces 3 failures: https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-868/1/

plugins.SshSlavesPluginTest.newAgent is flaky and can be ignored, fyi. See #867

NotMyFault avatar Jul 25 '22 14:07 NotMyFault

Tests should be passing now, just the ul to ol failure was caused by the breadcrumbs PR. Think something else broke the dashboard view tests but those are fixed now too 👍

Cheers for running them @NotMyFault :)

janfaracik avatar Jul 26 '22 14:07 janfaracik

Tests should be passing now, just the ul to ol failure was caused by the breadcrumbs PR. Think something else broke the dashboard view tests but those are fixed now too 👍

Thanks for addressing, plugins.DashboardViewPluginTest.unstableJobsPortlet_showOnlyFailedJobs didn't work out unfortunately :/

NotMyFault avatar Jul 26 '22 14:07 NotMyFault

Tests pass locally for me so hopefully updating to a new build sorts it

timja avatar Aug 17 '22 08:08 timja