Tim Jacomb

Results 1104 comments of Tim Jacomb
trafficstars

cc @jenkinsci/sig-ux

> > The CI build seems to fail on Windows. > > Windows attempts to enforce CRLF with prettier, but the files use LF, as configured. Doesn't seem to do...

> That was the case when I ran `lint:fix`. Figures, my surface had autocrlf set to true in its .gitconfig. Unsetting this behavior makes prettier not fail the build. It...

> I think this is pretty valuable feedback for this PR. Which was addressed by merging Daniel's 20 or so open PRs in this area. > Long lines are not...

> This could be done in a separate PR and merged in as a prerequisite to this PR sure, unfortunately non-trivial as `eslint` isn't currently ran across that sub-module, but...

> Will having prettier enabled affect current and future documentation updates throughout the ci repo? It may cause a minor linting issue which we can review as we go and...

> Have we considered maybe using something like [diffplug/spotless](https://github.com/diffplug/spotless), at least as a JVM managed way to configure it, but also that we can use for other formatting in the...

At a minimum integrating it with spotless would complicate updating it as the version of a JavaScript dependency would be encoded in a pom.xml file, (do-able but more effort)

> BTW I don't care how many PRs we use, but I feel strongly that we have at least two commits after all is integrated (one for the manual changes...

Do you know what caused it to lose this and is this undo-ing / affecting another change?